Reviewers: Kasper Lund, Message: some initial comments
http://codereview.chromium.org/7077/diff/1/9 File src/codegen-ia32.cc (right): http://codereview.chromium.org/7077/diff/1/9#newcode1235 Line 1235: bool call_constructor, Please change the bool parameter to an enum {FUNCTION, CONSTRUCTOR} to increase readability at the call sites. http://codereview.chromium.org/7077/diff/1/9#newcode2685 Line 2685: CallWithArguments(node->arguments(), true, node->position()); Nice refactoring! http://codereview.chromium.org/7077/diff/1/6 File src/objects.h (right): http://codereview.chromium.org/7077/diff/1/6#newcode2498 Line 2498: DECL_ACCESSORS(constructor, Code) The term constructor is overloaded here. I would prefer to use some different term like allocator. Description: Under construction: Preliminary change to support per function constructor stubs. Please review this at http://codereview.chromium.org/7077 Affected files: M src/builtins-ia32.cc M src/codegen-ia32.h M src/codegen-ia32.cc M src/heap.cc M src/macro-assembler-ia32.h M src/macro-assembler-ia32.cc M src/objects-inl.h M src/objects.h --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
