LGTM. Comments:
http://codereview.chromium.org/7226/diff/1/2 File src/ic-ia32.cc (right): http://codereview.chromium.org/7226/diff/1/2#newcode215 Line 215: Label slow, fast, check_string, slow_string; The slow_string label doesn't appear to be used? http://codereview.chromium.org/7226/diff/1/2#newcode248 Line 248: KeyedLoadIC::Generate(masm, ExternalReference(Runtime::kKeyedGetProperty)); Maybe you should port this change to ARM right away? Should be fairly trivial... http://codereview.chromium.org/7226/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/7226/diff/1/4#newcode1465 Line 1465: && key->IsString() Why not have the && on the previous line? http://codereview.chromium.org/7226/diff/1/4#newcode1466 Line 1466: && !JSObject::cast(receiver)->HasFastProperties()) { Ditto. http://codereview.chromium.org/7226/diff/1/4#newcode1470 Line 1470: && (dictionary->DetailsAt(entry).type() == NORMAL)) { Ditto. http://codereview.chromium.org/7226 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
