Sorry about that. The comment just seems wrong, though (preserve the top of stack in a register? when we're pushing a register to the top of the stack?). I think it's a leftover from TOS caching.
On Mon, Oct 13, 2008 at 12:42 PM, Mads Sig Ager <[EMAIL PROTECTED]> wrote: > > LGTM, please capitalize the comment. > > On Mon, Oct 13, 2008 at 12:41 PM, <[EMAIL PROTECTED]> wrote: > > Reviewers: Mads Ager, > > > > Message: > > Fix a lint error to make the tree green. > > > > Description: > > Fix lint error in codegen-ia32.cc. > > > > Please review this at http://codereview.chromium.org/7264 > > > > Affected files: > > M src/codegen-ia32.cc > > > > > > Index: src/codegen-ia32.cc > > =================================================================== > > --- src/codegen-ia32.cc (revision 489) > > +++ src/codegen-ia32.cc (working copy) > > @@ -2128,7 +2128,8 @@ > > frame_->Pop(Operand::StaticVariable(handler_address)); > > frame_->Drop(StackHandlerConstants::kSize / kPointerSize - 1); > > // next_sp popped. > > - frame_->Push(eax); // preserve the TOS in a register across stack > > manipulation > > + // preserve the TOS in a register across stack manipulation. > > + frame_->Push(eax); > > > > // --- Finally block --- > > __ bind(&finally_block); > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
