LGTM with comments

http://codereview.chromium.org/7297/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/7297/diff/1/2#newcode1001
Line 1001: static int BoyerMooreIndexOf(Vector<const schar> subject,
This function is too big now.  It has to be split up.  I would suggest:

BuildBadCharTable
BoyerMooreHorspool
BuildSuffixTable
BoyerMoore

http://codereview.chromium.org/7297

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to