LGTM On Wed, Oct 15, 2008 at 1:49 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Erik Corry, > > Message: > I couldn't ignore it. > > Description: > Code formatting changes. > > Please review this at http://codereview.chromium.org/7346 > > Affected files: > M src/codegen.cc > > > Index: src/codegen.cc > =================================================================== > --- src/codegen.cc (revision 506) > +++ src/codegen.cc (working copy) > @@ -345,9 +345,10 @@ > } > > > -void CodeGenerator::GenerateFastCaseSwitchStatement( > - SwitchStatement *node, int min_index, int range, int default_index) { > - > +void CodeGenerator::GenerateFastCaseSwitchStatement(SwitchStatement* node, > + int min_index, > + int range, > + int default_index) { > ZoneList<CaseClause*>* cases = node->cases(); > int length = cases->length(); > > @@ -357,8 +358,8 @@ > // Label per switch case > SmartPointer<Label> case_labels(NewArray<Label>(length)); > > - Label* fail_label = (default_index >= 0 ? &(case_labels[default_index]) > - : node->break_target()); > + Label* fail_label = default_index >= 0 ? &(case_labels[default_index]) > + : node->break_target(); > > // Populate array of label pointers for each number in the range. > // Initally put the failure label everywhere. > @@ -382,14 +383,15 @@ > case_targets, case_labels); > } > > + > void CodeGenerator::GenerateFastCaseSwitchCases( > - SwitchStatement* node, SmartPointer<Label> &case_labels) { > - > + SwitchStatement* node, > + SmartPointer<Label>& case_labels) { > ZoneList<CaseClause*>* cases = node->cases(); > int length = cases->length(); > > for (int i = 0; i < length; i++) { > - Comment cmnt(masm(), "[ case clause"); > + Comment cmnt(masm(), "[ Case clause"); > masm()->bind(&(case_labels[i])); > VisitStatements(cases->at(i)->statements()); > } > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
