Reviewers: Mads Ager, Description: Fix issue 116 by returning the value from SetFastElement.
Please review this at http://codereview.chromium.org/7615 Affected files: M src/objects.cc test/mjsunit/regress/regress-116.js Index: test/mjsunit/regress/regress-116.js =================================================================== --- test/mjsunit/regress/regress-116.js (revision 0) +++ test/mjsunit/regress/regress-116.js (revision 0) @@ -0,0 +1,40 @@ +// Copyright 2008 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +var testCache = {}; +var doLookup = function(id) { + return testCache[id] = 'foo'; +}; + +var r2 = doLookup(0); +var r1 = doLookup([0]); + +assertFalse(r1 === testCache); +assertEquals('foo', r1); +assertEquals('f', r1[0]); +assertEquals('foo', r2); +assertEquals('f', r2[0]); Index: src/objects.cc =================================================================== --- src/objects.cc (revision 513) +++ src/objects.cc (working copy) @@ -4655,7 +4655,7 @@ JSArray::cast(this)->set_length(Smi::FromInt(index + 1)); } } - return this; + return value; } // Allow gap in fast case. @@ -4670,7 +4670,7 @@ SetFastElements(FixedArray::cast(obj)); if (IsJSArray()) JSArray::cast(this)->set_length(Smi::FromInt(index + 1)); FixedArray::cast(elements())->set(index, value); - return this; + return value; } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
