I don't know why the regression test is not shown here. It is in the changelist.
-- Mads On Fri, Oct 17, 2008 at 9:15 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Apply fix for issue 116 from bleeding_edge branch. Update version > 0.3.5 to 0.3.5.1. > > > Please review this at http://codereview.chromium.org/7473 > > Affected files: > M src/api.cc > M src/objects.cc > > > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 511) > +++ src/api.cc (working copy) > @@ -2216,7 +2216,7 @@ > > > const char* v8::V8::GetVersion() { > - return "0.3.5"; > + return "0.3.5.1"; > } > > > Index: src/objects.cc > =================================================================== > --- src/objects.cc (revision 511) > +++ src/objects.cc (working copy) > @@ -4655,7 +4655,7 @@ > JSArray::cast(this)->set_length(Smi::FromInt(index + 1)); > } > } > - return this; > + return value; > } > > // Allow gap in fast case. > @@ -4670,7 +4670,7 @@ > SetFastElements(FixedArray::cast(obj)); > if (IsJSArray()) JSArray::cast(this)->set_length(Smi::FromInt(index + > 1)); > FixedArray::cast(elements())->set(index, value); > - return this; > + return value; > } > } > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
