LGTM except for trivial comments below. It's cute to solve a problem by *removing* a level of indirection. That's almost unheard of!
http://codereview.chromium.org/7619/diff/1/4 File src/heap.cc (right): http://codereview.chromium.org/7619/diff/1/4#newcode2325 Line 2325: for(uint32_t bitmask = 1; bitmask != 0; bitmask = bitmask << 1) { Need a space after 'for'. http://codereview.chromium.org/7619/diff/1/7 File src/spaces.cc (right): http://codereview.chromium.org/7619/diff/1/7#newcode765 Line 765: // Create a new space with a given allocation capacity (ie, the capacity of The comment is confusing because the capacity is not 'given' but found in a static heap variable. http://codereview.chromium.org/7619/diff/1/6 File src/spaces.h (right): http://codereview.chromium.org/7619/diff/1/6#newcode882 Line 882: SemiSpace() :Space(NEW_SPACE, NOT_EXECUTABLE) { A space (character) before 'Space'? http://codereview.chromium.org/7619 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
