LGTM, Lars
http://codereview.chromium.org/7518/diff/202/9 File src/objects.cc (right): http://codereview.chromium.org/7518/diff/202/9#newcode3652 Line 3652: static inline bool CompareRawStringContents(Vector<Char> a, Vector<Char> b) { How about an assert checking a.length() == b.length()? http://codereview.chromium.org/7518/diff/202/9#newcode3665 Line 3665: if (wa != wb) Move return false to previous line or add {}. http://codereview.chromium.org/7518/diff/202/9#newcode3669 Line 3669: for (; i < length; i++) Missing {} http://codereview.chromium.org/7518 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
