I wonder if we need to do something similar with the .vcproj files? On Tue, Oct 21, 2008 at 3:59 PM, <[EMAIL PROTECTED]> wrote: > > Reviewers: Christian Plesner Hansen, > > Description: > - Update js2c.py to take a type parameter. > - Use the type parameter in the Xcode run script phases when building > the > libraries.cc and libraries-empty.cc files. > > > Please review this at http://codereview.chromium.org/7814 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M tools/js2c.py > M tools/v8.xcodeproj/project.pbxproj > > > Index: tools/js2c.py > =================================================================== > --- tools/js2c.py (revision 535) > +++ tools/js2c.py (working copy) > @@ -349,8 +349,9 @@ > def main(): > natives = sys.argv[1] > natives_empty = sys.argv[2] > - source_files = sys.argv[3:] > - JS2C(source_files, [natives, natives_empty], None) > + type = sys.argv[3] > + source_files = sys.argv[4:] > + JS2C(source_files, [natives, natives_empty], { 'TYPE': type }) > > if __name__ == "__main__": > main() > Index: tools/v8.xcodeproj/project.pbxproj > =================================================================== > --- tools/v8.xcodeproj/project.pbxproj (revision 535) > +++ tools/v8.xcodeproj/project.pbxproj (working copy) > @@ -952,7 +952,7 @@ > ); > runOnlyForDeploymentPostprocessing = 0; > shellPath = /bin/sh; > - shellScript = "set -ex\nJS_FILES=\"runtime.js\"\\\n\" > v8natives.js\"\\\n\" array.js\"\\\n\" string.js\"\\\n\" uri.js\"\\\n\" > math.js\"\\\n\" messages.js\"\\\n\" apinatives.js\"\\\n\" > debug-delay.js\"\\\n\" mirror-delay.js\"\\\n\" date-delay.js\"\\\n\" > regexp-delay.js\"\\\n\" > macros.py\"\n\nV8ROOT=\"${SRCROOT}/..\"\n\nSRC_DIR=\"${V8ROOT}/src\"\n\nNATIVE_JS_FILES=\"\"\n\nfor > i in ${JS_FILES} ; do\n NATIVE_JS_FILES+=\"${SRC_DIR}/${i} > \"\ndone\n\nV8_GENERATED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nmkdir > -p > \"${V8_GENERATED_SOURCES_DIR}\"\n\nLIBRARIES_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries.cc\"\nLIBRARIES_EMPTY_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries-empty.cc\"\n\npython > \"${V8ROOT}/tools/js2c.py\" \\\n \"${LIBRARIES_CC}.new\" \\\n > \"${LIBRARIES_EMPTY_CC}.new\" \\\n ${NATIVE_JS_FILES}\n\n# Only use the > new files if they're different from the existing files (if any),\n# > preserving the existing files' timestamps when there are no changes. > This\n# minimizes unnecessary build activity for a no-change build.\n\nif ! > diff -q \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\" >& /dev/null ; then\n > mv \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\"\nelse\n rm > \"${LIBRARIES_CC}.new\"\nfi\n\nif ! diff -q \"${LIBRARIES_EMPTY_CC}.new\" > \"${LIBRARIES_EMPTY_CC}\" >& /dev/null ; then\n mv > \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\"\nelse\n rm > \"${LIBRARIES_EMPTY_CC}.new\"\nfi\n"; > + shellScript = "set -ex\nJS_FILES=\"runtime.js\"\\\n\" > v8natives.js\"\\\n\" array.js\"\\\n\" string.js\"\\\n\" uri.js\"\\\n\" > math.js\"\\\n\" messages.js\"\\\n\" apinatives.js\"\\\n\" > debug-delay.js\"\\\n\" mirror-delay.js\"\\\n\" date-delay.js\"\\\n\" > regexp-delay.js\"\\\n\" > macros.py\"\n\nV8ROOT=\"${SRCROOT}/..\"\n\nSRC_DIR=\"${V8ROOT}/src\"\n\nNATIVE_JS_FILES=\"\"\n\nfor > i in ${JS_FILES} ; do\n NATIVE_JS_FILES+=\"${SRC_DIR}/${i} > \"\ndone\n\nV8_GENERATED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nmkdir > -p > \"${V8_GENERATED_SOURCES_DIR}\"\n\nLIBRARIES_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries.cc\"\nLIBRARIES_EMPTY_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries-empty.cc\"\n\npython > \"${V8ROOT}/tools/js2c.py\" \\\n \"${LIBRARIES_CC}.new\" \\\n > \"${LIBRARIES_EMPTY_CC}.new\" \\\n \"CORE\" \\\n ${NATIVE_JS_FILES}\n\n# > Only use the new files if they're different from the existing files (if > any),\n# preserving the existing files' timestamps when there are no > changes. This\n# minimizes unnecessary build activity for a no-change > build.\n\nif ! diff -q \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\" >& > /dev/null ; then\n mv \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\"\nelse\n > rm \"${LIBRARIES_CC}.new\"\nfi\n\nif ! diff -q > \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\" >& /dev/null ; > then\n mv \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\"\nelse\n > rm \"${LIBRARIES_EMPTY_CC}.new\"\nfi\n"; > }; > 89F23C3D0E78D5B2006B2466 /* ShellScript */ = { > isa = PBXShellScriptBuildPhase; > @@ -965,7 +965,7 @@ > ); > runOnlyForDeploymentPostprocessing = 0; > shellPath = /bin/sh; > - shellScript = "set -ex\nJS_FILES=\"runtime.js\"\\\n\" > v8natives.js\"\\\n\" array.js\"\\\n\" string.js\"\\\n\" uri.js\"\\\n\" > math.js\"\\\n\" messages.js\"\\\n\" apinatives.js\"\\\n\" > debug-delay.js\"\\\n\" mirror-delay.js\"\\\n\" date-delay.js\"\\\n\" > regexp-delay.js\"\\\n\" > macros.py\"\n\nV8ROOT=\"${SRCROOT}/..\"\n\nSRC_DIR=\"${V8ROOT}/src\"\n\nNATIVE_JS_FILES=\"\"\n\nfor > i in ${JS_FILES} ; do\n NATIVE_JS_FILES+=\"${SRC_DIR}/${i} > \"\ndone\n\nV8_GENERATED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nmkdir > -p > \"${V8_GENERATED_SOURCES_DIR}\"\n\nLIBRARIES_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries.cc\"\nLIBRARIES_EMPTY_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries-empty.cc\"\n\npython > \"${V8ROOT}/tools/js2c.py\" \\\n \"${LIBRARIES_CC}.new\" \\\n > \"${LIBRARIES_EMPTY_CC}.new\" \\\n ${NATIVE_JS_FILES}\n\n# Only use the > new files if they're different from the existing files (if any),\n# > preserving the existing files' timestamps when there are no changes. > This\n# minimizes unnecessary build activity for a no-change build.\n\nif ! > diff -q \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\" >& /dev/null ; then\n > mv \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\"\nelse\n rm > \"${LIBRARIES_CC}.new\"\nfi\n\nif ! diff -q \"${LIBRARIES_EMPTY_CC}.new\" > \"${LIBRARIES_EMPTY_CC}\" >& /dev/null ; then\n mv > \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\"\nelse\n rm > \"${LIBRARIES_EMPTY_CC}.new\"\nfi\n"; > + shellScript = "set -ex\nJS_FILES=\"runtime.js\"\\\n\" > v8natives.js\"\\\n\" array.js\"\\\n\" string.js\"\\\n\" uri.js\"\\\n\" > math.js\"\\\n\" messages.js\"\\\n\" apinatives.js\"\\\n\" > debug-delay.js\"\\\n\" mirror-delay.js\"\\\n\" date-delay.js\"\\\n\" > regexp-delay.js\"\\\n\" > macros.py\"\n\nV8ROOT=\"${SRCROOT}/..\"\n\nSRC_DIR=\"${V8ROOT}/src\"\n\nNATIVE_JS_FILES=\"\"\n\nfor > i in ${JS_FILES} ; do\n NATIVE_JS_FILES+=\"${SRC_DIR}/${i} > \"\ndone\n\nV8_GENERATED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nmkdir > -p > \"${V8_GENERATED_SOURCES_DIR}\"\n\nLIBRARIES_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries.cc\"\nLIBRARIES_EMPTY_CC=\"${V8_GENERATED_SOURCES_DIR}/libraries-empty.cc\"\n\npython > \"${V8ROOT}/tools/js2c.py\" \\\n \"${LIBRARIES_CC}.new\" \\\n > \"${LIBRARIES_EMPTY_CC}.new\" \\\n \"CORE\" \\\n ${NATIVE_JS_FILES}\n\n# > Only use the new files if they're different from the existing files (if > any),\n# preserving the existing files' timestamps when there are no > changes. This\n# minimizes unnecessary build activity for a no-change > build.\n\nif ! diff -q \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\" >& > /dev/null ; then\n mv \"${LIBRARIES_CC}.new\" \"${LIBRARIES_CC}\"\nelse\n > rm \"${LIBRARIES_CC}.new\"\nfi\n\nif ! diff -q > \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\" >& /dev/null ; > then\n mv \"${LIBRARIES_EMPTY_CC}.new\" \"${LIBRARIES_EMPTY_CC}\"\nelse\n > rm \"${LIBRARIES_EMPTY_CC}.new\"\nfi\n"; > }; > /* End PBXShellScriptBuildPhase section */ > > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
