On Tue, Oct 21, 2008 at 6:59 PM, <[EMAIL PROTECTED]> wrote: > > http://codereview.chromium.org/7669/diff/401/404#newcode774 > Line 774: __ push(eax); > This push here relies on the fact that the code generators VirtualFrame > frame_ maps directly to the machine frame. I think this should be > changed to return the result in eax. >
We currently have the same confusion whenever we call to deferred code, because the starting virtual frame is not passed to deferred code and the expected frame when it jumps back is not present. Getting that working requires splitting and merging virtual frames along control flow paths, which I'm working on right now. I think it's probably OK to leave this as is for now if it avoids a temporary performance regression (maybe with a comment), because it will be sorted out when the virtual frame starts flowing properly to deferred code. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
