Author: [EMAIL PROTECTED]
Date: Tue Oct 21 23:30:29 2008
New Revision: 546
Modified:
branches/bleeding_edge/src/api.cc
Log:
Added handling of empty handles to String::AsciiValue and String::Value.
Review URL: http://codereview.chromium.org/7832
Modified: branches/bleeding_edge/src/api.cc
==============================================================================
--- branches/bleeding_edge/src/api.cc (original)
+++ branches/bleeding_edge/src/api.cc Tue Oct 21 23:30:29 2008
@@ -2689,6 +2689,11 @@
String::AsciiValue::AsciiValue(v8::Handle<v8::Value> obj) {
EnsureInitialized("v8::String::AsciiValue::AsciiValue()");
+ if (obj.IsEmpty()) {
+ str_ = NULL;
+ length_ = 0;
+ return;
+ }
HandleScope scope;
TryCatch try_catch;
Handle<String> str = obj->ToString();
@@ -2710,6 +2715,11 @@
String::Value::Value(v8::Handle<v8::Value> obj) {
EnsureInitialized("v8::String::Value::Value()");
+ if (obj.IsEmpty()) {
+ str_ = NULL;
+ length_ = 0;
+ return;
+ }
HandleScope scope;
TryCatch try_catch;
Handle<String> str = obj->ToString();
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
