LGTM.
http://codereview.chromium.org/7863/diff/1/4 File src/heap.cc (right): http://codereview.chromium.org/7863/diff/1/4#newcode1765 Line 1765: Object* clone = new_space_.AllocateRaw(object_size); Extra space before new_space_. http://codereview.chromium.org/7863/diff/1/4#newcode1778 Line 1778: Object* elem = Heap::CopyFixedArray(elements); Extra space before Heap. http://codereview.chromium.org/7863/diff/1/9 File src/objects.h (right): http://codereview.chromium.org/7863/diff/1/9#newcode815 Line 815: static inline Failure* RetryAfterGC(int requested_bytes); // NEW_SPACE How about renaming this to avoid the overloading? Something like RetryAfterNewSpaceGC might do the trick? Then you could also get rid of the comment. http://codereview.chromium.org/7863 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
