http://codereview.chromium.org/8011/diff/1/2 File src/heap.cc (right):
http://codereview.chromium.org/8011/diff/1/2#newcode1359 Line 1359: byte* dest = SeqAsciiString::cast(result)->GetCharsAddress(); I've tried to use char consistently, since the name fits the use and the problems with signed vs. unsigned char shouldn't matter for ASCII. http://codereview.chromium.org/8011/diff/1/7 File src/objects-inl.h (right): http://codereview.chromium.org/8011/diff/1/7#newcode1372 Line 1372: int String::full_representation_tag() { This one is certainly trivial. http://codereview.chromium.org/8011/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/8011/diff/1/3#newcode547 Line 547: SeqTwoByteString::cast(result)->GetCharsAddress()); Good idea. http://codereview.chromium.org/8011/diff/1/3#newcode2914 Line 2914: const byte* start = reinterpret_cast<const byte*>(ext->resource()->data()); Done http://codereview.chromium.org/8011/diff/1/3#newcode3591 Line 3591: memcpy( Done. http://codereview.chromium.org/8011/diff/1/3#newcode3606 Line 3606: case kTwoByteStringTag + kExternalStringTag: { Done http://codereview.chromium.org/8011/diff/1/3#newcode3616 Line 3616: const byte* src = The non-memcpy may be marginally faster, but this is removed in the new version. http://codereview.chromium.org/8011/diff/1/3#newcode3623 Line 3623: Cpy168( Gone in new version. http://codereview.chromium.org/8011/diff/1/3#newcode3652 Line 3652: if (boundary < 64 || to - boundary >= boundary - from) { I got rid of this optimization because I found a test failure and the fix would probably deoptimize the optimization. http://codereview.chromium.org/8011/diff/1/3#newcode3748 Line 3748: VectorIterator<const byte> ib(b->ToAsciiVector()); OK http://codereview.chromium.org/8011/diff/1/6 File src/utils.h (right): http://codereview.chromium.org/8011/diff/1/6#newcode451 Line 451: static inline void Cpy168(sinkchar* dest, const unsigned char* src, int chars) { Can't do this because of alignment issues. http://codereview.chromium.org/8011 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
