On Wed, Oct 22, 2008 at 3:36 PM, <[EMAIL PROTECTED]> wrote: > Lgtm. > > I'm assuming that you ran your asterisk-after-the-type regexp to find > most of these violations. Maybe we should add a python version to the > presubmit script?
Yes, we should. > > > > http://codereview.chromium.org/8055/diff/1/4 > File src/codegen-ia32.h (right): > > http://codereview.chromium.org/8055/diff/1/4#newcode376 > Line 376: SmartPointer<Label*>& case_targets, > I know you didn't originally write this but passing a smart pointer by > reference looks really unhealthy. We should either use the Label* > directly or use a pointer to the smart pointer rather than a reference. I decided to use Vectors instead. > > > http://codereview.chromium.org/8055/diff/1/5 > File src/runtime.cc (right): > > http://codereview.chromium.org/8055/diff/1/5#newcode104 > Line 104: bool& is_result_from_cache) { > Yuck, output parameters should always be pointers not references. Fixed. > > > http://codereview.chromium.org/8055/diff/1/5#newcode1238 > Line 1238: bool& complete) { > Yuck ditto! Fixed. > > > http://codereview.chromium.org/8055 > New version uploaded. -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
