LGTM, Lars
http://codereview.chromium.org/7879/diff/1/4 File src/heap-inl.h (right): http://codereview.chromium.org/7879/diff/1/4#newcode173 Line 173: } Use keyed_lookup_cache() instead of keyed_lookup_cache_. http://codereview.chromium.org/7879/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/7879/diff/1/2#newcode1199 Line 1199: // Initialize keyed lookup cache. Use ClearKeyedLookupCache(); http://codereview.chromium.org/7879/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/7879/diff/1/3#newcode5885 Line 5885: virtual bool IsMatch(Object* other) { Why do you use the virtual keyword in this class? Please make it consistent with SymbolsKey etc. http://codereview.chromium.org/7879/diff/1/3#newcode5958 Line 5958: if (entry != -1) { I find this easier to read. if (entry == -1) return -1; return Smi::cast(get(EntryToIndex(entry) + 1))->value(); http://codereview.chromium.org/7879/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/7879/diff/1/5#newcode1694 Line 1694: int offset = cache->Lookup(receiver_map, key); It might be a good idea to use a kNotFound constant for -1. http://codereview.chromium.org/7879 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
