As discussed, using the word "named" to only mean non-integer
properties in the api was a mistake and we should move towards
unifying the functionality for manipulating string and integer
properties as much as possible (and have already to some degree).
On Thu, Oct 23, 2008 at 12:21 PM, Kasper Lund <[EMAIL PROTECTED]> wrote:
> Well, I don't think GetPropertyNames really signals that you'll get
> array indexes back too, but maybe that's just me.
>
> On Thu, Oct 23, 2008 at 12:17 PM, Christian Plesner Hansen
> <[EMAIL PROTECTED]> wrote:
>> What about GetPropertyNames instead, since that is the terminology
>> used by the spec ("Get the name of the next property in Result(4) that
>> doesn't have the DontEnum attribute")?
>>
>> On Thu, Oct 23, 2008 at 12:13 PM, <[EMAIL PROTECTED]> wrote:
>>> LGTM, maybe with a better name?
>>>
>>>
>>> http://codereview.chromium.org/7912/diff/1/2
>>> File include/v8.h (right):
>>>
>>> http://codereview.chromium.org/7912/diff/1/2#newcode1025
>>> Line 1025: Local<Array> GetProperties();
>>> Should this have a comment that describes what this function does (like
>>> the fact that you only get enumerable properties back)? I think it
>>> should be renamed to GetPropertyKeys, so it's clear you're not getting
>>> the values back.
>>>
>>> http://codereview.chromium.org/7912
>>>
>>
>
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
