Greatness. LGTM. On Thu, Oct 23, 2008 at 5:04 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Fixed usage of NewArgumentsObject for accessor. > > > Please review this at http://codereview.chromium.org/7917 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/accessors.cc > > > Index: src/accessors.cc > =================================================================== > --- src/accessors.cc (revision 573) > +++ src/accessors.cc (working copy) > @@ -382,11 +382,12 @@ > // mirror for the right frame. > const int length = frame->GetProvidedParametersCount(); > Handle<JSObject> arguments = Factory::NewArgumentsObject(function, > length); > + Handle<FixedArray> array = Factory::NewFixedArray(length); > > // Copy the parameters to the arguments object. > - FixedArray* array = FixedArray::cast(arguments->elements()); > ASSERT(array->length() == length); > for (int i = 0; i < length; i++) array->set(i, frame->GetParameter(i)); > + arguments->set_elements(*array); > > // Return the freshly allocated arguments object. > return *arguments; > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
