Hello [EMAIL PROTECTED], I'd like you to do a code review. To review this change, run
gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PROTECTED]/issue122 to review the following change: [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-10-24 10:27:53 +-100 (Fri, 24 Oct 2008) Description: Changed the workarround for a GCC compiler bug to be only active for the GCC version range for which the bug is known to exist. Added include to compile with GCC 4.3.1. BUG=122 Affected Paths: M //branches/bleeding_edge/src/top.h M //branches/bleeding_edge/test/cctest/test-api.cc This is a semiautomated message from "gvn mail". See <http://code.google.com/p/gvn/> to learn more. Index: src/top.h =================================================================== --- src/top.h (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) +++ src/top.h (^/changes/[EMAIL PROTECTED]/issue122/bleeding_edge/src/[EMAIL PROTECTED]) @@ -300,14 +300,14 @@ class Top { }; -// TODO(122): If the GCC version is 4.2.0 or higher an additional field is added -// to this class as a workarround for a bug in the generated code found with -// GCC 4.2.3. +// If the GCC version is 4.1.x or 4.2.x an additional field is added to the +// class as a workarround for a bug in the generated code found with these +// versions of GCC. See V8 issue 122 for details. class SaveContext BASE_EMBEDDED { public: SaveContext() : context_(Top::context()), -#if __GNUC_VERSION__ >= 40200 +#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300 dummy_(Top::context()), #endif prev_(Top::save_context()) { @@ -324,7 +324,7 @@ class SaveContext BASE_EMBEDDED { private: Handle<Context> context_; -#if __GNUC_VERSION__ >= 40200 +#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300 Handle<Context> dummy_; #endif SaveContext* prev_; Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (^/branches/bleeding_edge/test/cctest/[EMAIL PROTECTED]) +++ test/cctest/test-api.cc (^/changes/[EMAIL PROTECTED]/issue122/bleeding_edge/test/cctest/[EMAIL PROTECTED]) @@ -28,6 +28,8 @@ #include <map> #include <string> +#include <stdlib.h> + #include "v8.h" #include "api.h" --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
