lgtm, I will check this in for you. On Fri, Oct 24, 2008 at 2:35 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Feng Qian, > > Description: > Remove unused strcasecmp function. > > It conflicted with one defined in webkit/wtf/StringExtras.h > > > Please review this at http://codereview.chromium.org/7989 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/platform-win32.cc > M src/platform.h > > > Index: src/platform-win32.cc > =================================================================== > --- src/platform-win32.cc (revision 539) > +++ src/platform-win32.cc (working copy) > @@ -153,13 +153,6 @@ > } > > > -// Case-insensitive string comparisons. Use stricmp() on Win32. Usually > defined > -// in strings.h. > -int strcasecmp(const char* s1, const char* s2) { > - return _stricmp(s1, s2); > -} > - > - > // Case-insensitive bounded string comparisons. Use stricmp() on Win32. > Usually > // defined in strings.h. > int strncasecmp(const char* s1, const char* s2, int n) { > Index: src/platform.h > =================================================================== > --- src/platform.h (revision 539) > +++ src/platform.h (working copy) > @@ -68,7 +68,6 @@ > > int random(); > > -int strcasecmp(const char* s1, const char* s2); > int strncasecmp(const char* s1, const char* s2, int n); > > #else > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
