I think you should let Mads take a look at the specifics of the length encoding. I have more general comments:
1. Does this work on ARM? 2. Does it lint? http://codereview.chromium.org/8187/diff/1/12 File src/codegen-ia32.cc (right): http://codereview.chromium.org/8187/diff/1/12#newcode2859 Line 2859: // The code assumes the tags are serendpitous. Please choose a better word than serendpitous. Preferably one you can spell :-) http://codereview.chromium.org/8187/diff/1/12#newcode2861 Line 2861: ASSERT(kMediumStringTag + String::kLongLengthShift == String::kMediumLengthShift); Is this line too long? http://codereview.chromium.org/8187/diff/1/12#newcode2862 Line 2862: ASSERT(kShortStringTag + String::kLongLengthShift == String::kShortLengthShift); Ditto? http://codereview.chromium.org/8187 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
