Ugh. LGTM. On Mon, Oct 27, 2008 at 10:48 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Erik Corry, > > Description: > Fix issue 128. > > Please review this at http://codereview.chromium.org/8617 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/jsregexp.cc > > > Index: src/jsregexp.cc > =================================================================== > --- src/jsregexp.cc (revision 595) > +++ src/jsregexp.cc (working copy) > @@ -30,12 +30,21 @@ > #include "execution.h" > #include "factory.h" > #include "jsregexp.h" > -#include "third_party/jscre/pcre.h" > #include "platform.h" > #include "runtime.h" > #include "top.h" > #include "compilation-cache.h" > > +// Including pcre.h undefines DEBUG to avoid getting debug output from > +// the JSCRE implementation. Make sure to redefine it in debug mode > +// after having included the header file. > +#ifdef DEBUG > +#include "third_party/jscre/pcre.h" > +#define DEBUG > +#else > +#include "third_party/jscre/pcre.h" > +#endif > + > namespace v8 { namespace internal { > > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
