I'd probably remove the print statement. Otherwise lgtm.
On Mon, Oct 27, 2008 at 3:04 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: plesner, > > Description: > Test for a bug that was fixed in r554 where we used unaligned accesses > on ARM > with surprising results. > > Please review this at http://codereview.chromium.org/8619 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > test/mjsunit/string-compare-alignment.js > > > Index: test/mjsunit/string-compare-alignment.js > =================================================================== > --- test/mjsunit/string-compare-alignment.js (revision 0) > +++ test/mjsunit/string-compare-alignment.js (revision 0) > @@ -0,0 +1,48 @@ > +// Copyright 2008 the V8 project authors. All rights reserved. > +// Redistribution and use in source and binary forms, with or without > +// modification, are permitted provided that the following conditions are > +// met: > +// > +// * Redistributions of source code must retain the above copyright > +// notice, this list of conditions and the following disclaimer. > +// * Redistributions in binary form must reproduce the above > +// copyright notice, this list of conditions and the following > +// disclaimer in the documentation and/or other materials provided > +// with the distribution. > +// * Neither the name of Google Inc. nor the names of its > +// contributors may be used to endorse or promote products derived > +// from this software without specific prior written permission. > +// > +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +// Test that we can compare two strings that are not 4-byte aligned. > +// This situation can arise with sliced strings. This tests for an ARM bug > +// that was fixed in r554. > + > +var base = "Now is the time for all good men to come to the aid of the > party. " + > + "Now is the time for all good men to come to the aid of the > party." > +var s1 = base.substring(0, 64); > +var s2 = base.substring(66, 130); > + > +var o = new Object(); > +o[s1] = 1; > +o[s2] = 2; > + > +var first_time = true; > + > +for (var x in o) { > + assertTrue(o[x] == 2, "expect 2"); > + assertTrue(first_time, "once only"); > + first_time = false; > + print(x + ": " + o[x]); > +} > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
