I only skimmed it. Looks good to me.
http://codereview.chromium.org/8188/diff/1/3 File src/ast.h (right): http://codereview.chromium.org/8188/diff/1/3#newcode1184 Line 1184: // Regular expressions full stop http://codereview.chromium.org/8188/diff/1/3#newcode1266 Line 1266: unsigned from() { return from_; } ASSERT !special? http://codereview.chromium.org/8188/diff/1/3#newcode1271 Line 1271: unsigned from_ : 21; JS Regexps don't handle anything outside the basic plane. Should these be 16 bit? http://codereview.chromium.org/8188/diff/1/6 File src/jsregexp.cc (right): http://codereview.chromium.org/8188/diff/1/6#newcode647 Line 647: // Dot/dotty output Cool idea :-) http://codereview.chromium.org/8188/diff/1/9 File src/parser.cc (right): http://codereview.chromium.org/8188/diff/1/9#newcode3271 Line 3271: return c == '|' || c == ')' || c == '\0'; This probably won't work in the long run, can't JS strings contain nulls? http://codereview.chromium.org/8188 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
