http://codereview.chromium.org/7990/diff/1/4 File src/runtime.cc (right):
http://codereview.chromium.org/7990/diff/1/4#newcode3990 Line 3990: class ArrayConcatVisitor { On 2008/10/25 00:29:19, iposva wrote: > Comments please. Done. http://codereview.chromium.org/7990/diff/1/4#newcode4014 Line 4014: static uint32_t VisitElements(Handle<JSObject> receiver, Renamed to IterateElements. On 2008/10/25 00:29:19, iposva wrote: > This function should probably be renamed IterateArrayElements() to avoid > confusion with a real Visitor. > Also please add more general comments about this function please. http://codereview.chromium.org/7990/diff/1/4#newcode4058 Line 4058: static uint32_t VisitArrayElements(Handle<JSArray> array, On 2008/10/25 00:29:19, iposva wrote: > This function should probably be renamed IterateArrayElements. Done. http://codereview.chromium.org/7990/diff/1/4#newcode4065 Line 4065: List<Handle<JSObject> > objects(kEstimatedPrototypes); Ok, I saw we use List< Handle<JSObject> > in other places, I will put a space between <<. On 2008/10/25 00:29:19, iposva wrote: > Extra space in "List<Handle<JSObject> >"? Slightly confusing as it tends to read > as a "greater than" operator. > http://codereview.chromium.org/7990/diff/1/4#newcode4084 Line 4084: static uint32_t VisitArrays(Handle<JSArray> arrays, On 2008/10/25 00:29:19, iposva wrote: > This should probably be renamed to IterateArguments, because you really iterate > over the arguments being passed to Array.Concat. Also please adjust the internal > variable names accordingly. Done. http://codereview.chromium.org/7990/diff/1/4#newcode4140 Line 4140: uint32_t estimate_nof_elements = VisitArrays(arrays, 0); On 2008/10/25 00:29:19, iposva wrote: > 0 should probably be NULL Done. http://codereview.chromium.org/7990 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
