LGTM. You should talk to Christian about the !FLAG_log tests in general. On Tue, Oct 28, 2008 at 10:33 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Fixing profiling when using snapshot. > > Please review this at http://codereview.chromium.org/8655 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/log.h > M src/log.cc > > > Index: src/log.cc > =================================================================== > --- src/log.cc (revision 620) > +++ src/log.cc (working copy) > @@ -259,7 +259,7 @@ > > void Logger::Preamble(const char* content) { > #ifdef ENABLE_LOGGING_AND_PROFILING > - if (logfile_ == NULL || !FLAG_log) return; > + if (logfile_ == NULL || !FLAG_log_code) return; > ScopedLock sl(mutex_); > fprintf(logfile_, "%s", content); > #endif > Index: src/log.h > =================================================================== > --- src/log.h (revision 620) > +++ src/log.h (working copy) > @@ -109,7 +109,8 @@ > > // Write a raw string to the log to be used as a preamble. > // No check is made that the 'preamble' is actually at the beginning > - // of the log. > + // of the log. The preample is used to write code events saved in the > + // snapshot. > static void Preamble(const char* content); > > // ==== Events that are always logged. ==== > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
