lgtm, thanks On Tue, Oct 28, 2008 at 7:54 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Feng Qian, > > Description: > Fix lint issues. > > [EMAIL PROTECTED] > > Please review this at http://codereview.chromium.org/8659 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/runtime.cc > > > Index: src/runtime.cc > =================================================================== > --- src/runtime.cc (revision 625) > +++ src/runtime.cc (working copy) > @@ -4085,7 +4085,7 @@ > * Elements on prototypes are visited first, and only elements whose indices > * less than Array length are visited. > * > - * If a ArrayConcatVisitor object is given, the visitor is called with > + * If a ArrayConcatVisitor object is given, the visitor is called with > * parameters, element's index + visitor_index_offset and the element. > */ > static uint32_t IterateArrayAndPrototypeElements(Handle<JSArray> array, > @@ -4101,7 +4101,7 @@ > // the prototype element before the shadowing element. > // The visitor can simply overwrite the old value by new value using > // the same index. This follows Array::concat semantics. > - while(!obj->IsNull()) { > + while (!obj->IsNull()) { > objects.Add(obj); > obj = Handle<Object>(obj->GetPrototype()); > } > @@ -4113,7 +4113,7 @@ > IterateElements(Handle<JSObject>::cast(obj), range, visitor); > } > > - return nof_elements; > + return nof_elements; > } > > > @@ -4151,7 +4151,7 @@ > visitor->increase_index_offset(1); > } > visited_elements++; > - } > + } > } > return visited_elements; > } > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
