http://codereview.chromium.org/8676/diff/1/3 File src/platform-win32.cc (right):
http://codereview.chromium.org/8676/diff/1/3#newcode786 Line 786: abort(); On 2008/10/28 21:45:38, Nicolas Sylvain wrote: > AFAIK abort is not going to work in the sandbox because it tries to display a > message box, and that does not work in the sandbox. When is OS::Abort() > called? Is it considered a fatal failure? If so, we need to be sure that it > generates a crash and breakpad catches it. You are right that in a Windows application abort() by default puts up a message box whereas it in a console application will print a message before it exits the program with exit code 3 skipping most at_exit processing. OS::Abort is called by default by V8 when there is a fatal error e.g. out of memory condition. Through the V8 API a fatal error handler can be registered, and in http://codereview.chromium.org/8838 I updated the fatal error handler added by Chrome to ensure a crash making Chrome independant of whatever default fatal error handling V8 supplies. I will add calls to _set_abort_behavior to make abort() totally silent. http://codereview.chromium.org/8676 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
