http://codereview.chromium.org/8835/diff/229/239 File src/rewriter.cc (right):
http://codereview.chromium.org/8835/diff/229/239#newcode58 Line 58: void AstOptimizer::Optimize(ZoneList<Statement*>* statements) { Agreed, but not in this change list. On 2008/10/28 19:10:41, Kevin Millikin wrote: > The Visitor base class should have VisitStatements and VisitExpressions that do > just this by default. http://codereview.chromium.org/8835/diff/229/239#newcode95 Line 95: if (node->init()) { Agreed and fixed. I was just mimicking other style from similar methods. On 2008/10/28 19:10:41, Kevin Millikin wrote: > I prefer explicit "!= NULL" here. It seems to fit the rest of our code base. http://codereview.chromium.org/8835/diff/229/233 File src/variables.h (right): http://codereview.chromium.org/8835/diff/229/233#newcode86 Line 86: static char* Type2String(StaticType* type); Again, I agree with your general suggestion, but I will leave this alone until we change the other code that is in this style such as Variable::Mode2String(). Preferably we could use type()->ToString() instead of StaticType::Type2String(type()). On 2008/10/28 19:10:41, Kevin Millikin wrote: > ToString is a better name. http://codereview.chromium.org/8835 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
