LGTM. On Tue, Oct 28, 2008 at 11:46 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Fix compile failure with very strict gcc warning rules on Linux. > > TBR=kasperl > > > Please review this at http://codereview.chromium.org/8857 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/variables.h > M src/variables.cc > > > Index: src/variables.h > =================================================================== > --- src/variables.h (revision 630) > +++ src/variables.h (working copy) > @@ -83,7 +83,7 @@ > kind_ = other->kind_; > } > > - static char* Type2String(StaticType* type); > + static const char* Type2String(StaticType* type); > > // LIKELY_SMI accessors > void SetAsLikelySmi() { > Index: src/variables.cc > =================================================================== > --- src/variables.cc (revision 630) > +++ src/variables.cc (working copy) > @@ -88,7 +88,7 @@ > // Implementation StaticType. > > > -char* StaticType::Type2String(StaticType* type) { > +const char* StaticType::Type2String(StaticType* type) { > switch (type->kind_) { > case UNKNOWN: > return "UNKNOWN"; > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
