Reviewers: Kasper Lund, Description: Because allocation in large object space can now require checking the size of the entire old generation, the heap must be (more) properly set up to test the large object space.
Please review this at http://codereview.chromium.org/8872 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-spaces.cc Index: test/cctest/test-spaces.cc =================================================================== --- test/cctest/test-spaces.cc (revision 631) +++ test/cctest/test-spaces.cc (working copy) @@ -208,7 +208,8 @@ TEST(LargeObjectSpace) { CHECK(Heap::ConfigureHeapDefault()); - MemoryAllocator::Setup(Heap::MaxCapacity()); + CHECK(MemoryAllocator::Setup(Heap::MaxCapacity())); + CHECK(Heap::Setup(false)); LargeObjectSpace* lo = new LargeObjectSpace(LO_SPACE); CHECK(lo != NULL); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
