I just changed SKIP to CRASH in the status file as the outcome of a crashed test was already being set to CRASH in the test frameweok. On Wed, Oct 29, 2008 at 2:27 PM, Kasper Lund <[EMAIL PROTECTED]> wrote:
> > LGTM. Would it make sense to have a CRASH marker that would run the > test and expect it to crash? This way we would know once we fix > something and it would stick out in the status file. At least you > should introduce a new marker called CRASH and let that be SKIP: > > def CRASH = SKIP > > and change all the new SKIPs to CRASH. I think that works. > > On Wed, Oct 29, 2008 at 2:24 PM, <[EMAIL PROTECTED]> wrote: > > > > Reviewers: Kasper Lund, > > > > Description: > > Skip the tests which currently crash on the ARM simulator. > > > > Please review this at http://codereview.chromium.org/8696 > > > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > > > Affected files: > > M test/mjsunit/mjsunit.status > > > > > > Index: test/mjsunit/mjsunit.status > > =================================================================== > > --- test/mjsunit/mjsunit.status (revision 637) > > +++ test/mjsunit/mjsunit.status (working copy) > > @@ -41,26 +41,26 @@ > > debug-scripts-request: PASS, SKIP if $mode == debug > > > > # Bug number 1020483: Debug tests fail on ARM. > > -debug-constructor: FAIL > > -debug-continue: FAIL > > +debug-constructor: SKIP > > +debug-continue: SKIP > > debug-backtrace-text: FAIL > > -debug-backtrace: FAIL > > -debug-evaluate-recursive: FAIL > > -debug-changebreakpoint: FAIL > > -debug-clearbreakpoint: FAIL > > -debug-conditional-breakpoints: FAIL > > -debug-enable-disable-breakpoints: FAIL > > -debug-evaluate: FAIL > > -debug-event-listener: FAIL > > -debug-ignore-breakpoints: FAIL > > -debug-multiple-breakpoints: FAIL > > -debug-setbreakpoint: FAIL > > -debug-step-stub-callfunction: FAIL > > -debug-stepin-constructor: FAIL > > -debug-step: FAIL > > +debug-backtrace: SKIP > > +debug-evaluate-recursive: SKIP > > +debug-changebreakpoint: SKIP > > +debug-clearbreakpoint: SKIP > > +debug-conditional-breakpoints: SKIP > > +debug-enable-disable-breakpoints: SKIP > > +debug-evaluate: SKIP > > +debug-event-listener: SKIP > > +debug-ignore-breakpoints: SKIP > > +debug-multiple-breakpoints: SKIP > > +debug-setbreakpoint: SKIP > > +debug-step-stub-callfunction: SKIP > > +debug-stepin-constructor: SKIP > > +debug-step: SKIP > > debug-breakpoints: PASS || FAIL > > > > -regress/regress-998565: FAIL > > +regress/regress-998565: SKIP > > > > # Bug number 130 http://code.google.com/p/v8/issues/detail?id=130 > > # Fails on real ARM hardware but not on the simulator. > > > > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
