LGTM. On Thu, Oct 30, 2008 at 12:36 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Move assertion that might cause garbage collections to before > extracting raw pointers. > > Please review this at http://codereview.chromium.org/8913 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/runtime.cc > > > Index: src/runtime.cc > =================================================================== > --- src/runtime.cc (revision 652) > +++ src/runtime.cc (working copy) > @@ -3439,8 +3439,8 @@ > > // If the holder is found, we read the property from it. > if (!holder.is_null() && holder->IsJSObject()) { > + ASSERT(Handle<JSObject>::cast(holder)->HasProperty(*name)); > JSObject* object = JSObject::cast(*holder); > - ASSERT(object->HasProperty(*name)); > JSObject* receiver = (object->IsGlobalObject()) > ? GlobalObject::cast(object)->global_receiver() > : ComputeReceiverForNonGlobal(object); > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
