LGTM.
http://codereview.chromium.org/8914/diff/1/6 File src/apinatives.js (right): http://codereview.chromium.org/8914/diff/1/6#newcode94 Line 94: if (requires_access_checks) %EnableAccessChecks(obj); Should this be in some sort of try-finally to play it safely? http://codereview.chromium.org/8914/diff/1/5 File src/objects.cc (right): http://codereview.chromium.org/8914/diff/1/5#newcode2302 Line 2302: // to be overwriten because allowing overwriting could potentially overwritten http://codereview.chromium.org/8914 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
