Reviewers: Kevin Millikin, Description: Ignore result of calling Heap::CollectGarbage and continue to try the next allocation. This is consistent with how we handle it when calling from JavaScript to C++.
Please review this at http://codereview.chromium.org/8916 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/heap-inl.h Index: src/heap-inl.h =================================================================== --- src/heap-inl.h (revision 655) +++ src/heap-inl.h (working copy) @@ -222,12 +222,8 @@ v8::internal::V8::FatalProcessOutOfMemory("CALL_AND_RETRY_0"); \ } \ if (!__object__->IsRetryAfterGC()) return RETURN_EMPTY; \ - if (!Heap::CollectGarbage( \ - Failure::cast(__object__)->requested(), \ - Failure::cast(__object__)->allocation_space())) { \ - v8::internal::V8::FatalProcessOutOfMemory("CALL_AND_RETRY_1"); \ - return RETURN_EMPTY; \ - } \ + Heap::CollectGarbage(Failure::cast(__object__)->requested(), \ + Failure::cast(__object__)->allocation_space()); \ __object__ = FUNCTION_CALL; \ if (!__object__->IsFailure()) return RETURN_VALUE; \ if (__object__->IsOutOfMemoryFailure()) { \ --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
