Lgtm

On Thu, Oct 30, 2008 at 4:52 PM,  <[EMAIL PROTECTED]> wrote:
> Reviewers: Christian Plesner Hansen,
>
> Description:
> Changed the parsing a conditional expression in a test status file to
> look for 'if' and not 'IF' as all the status files use 'if'.
>
> This change catches the regression from r646.
>
> Please review this at http://codereview.chromium.org/8739
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected files:
>  M     tools/test.py
>
>
> Index: tools/test.py
> ===================================================================
> --- tools/test.py       (revision 661)
> +++ tools/test.py       (working copy)
> @@ -886,7 +886,7 @@
>  def ParseConditionalExpression(scan):
>   left = ParseOperatorExpression(scan)
>   if not left: return None
> -  while scan.HasMore() and (scan.Current() == 'IF'):
> +  while scan.HasMore() and (scan.Current() == 'if'):
>     scan.Advance()
>     right = ParseOperatorExpression(scan)
>     if not right:
>
>
>

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to