Lgtm!
http://codereview.chromium.org/8760/diff/1/5 File regexp2000/src/objects.h (right): http://codereview.chromium.org/8760/diff/1/5#newcode2905 Line 2905: // NOT_COMPILED: A complex regexp for JSCRE that hasn't been compiled yet. As discussed I would use JSCRE for regexps that we know JSCRE should handle independent of whether it has been compiled yet. If we can it will be simpler if tags are constant. http://codereview.chromium.org/8760/diff/1/6 File regexp2000/src/parser.cc (right): http://codereview.chromium.org/8760/diff/1/6#newcode3823 Line 3823: static const char* kRangeOutOfOrder = "range out of order in character class"; I assume this error message reads the way it does for compatibility reasons. I suggest we introduce an incompatibility and start with an upper-case R. All our other error messages (withing regexps or not) start with an upper-case letter. http://codereview.chromium.org/8760 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
