Lgtm.
http://codereview.chromium.org/8765/diff/1/4 File regexp2000/src/jsregexp.cc (right): http://codereview.chromium.org/8765/diff/1/4#newcode340 Line 340: ASSERT(re->TypeTag() == JSRegExp::JSCRE); Use ASSERT_EQ(a, b) instead of ASSERT(a == b) since it displays the values when it fails. http://codereview.chromium.org/8765/diff/1/4#newcode509 Line 509: ASSERT(regexp->TypeTag() == JSRegExp::JSCRE); Ditto http://codereview.chromium.org/8765/diff/1/4#newcode536 Line 536: ASSERT(regexp->TypeTag() == JSRegExp::JSCRE); Ditto http://codereview.chromium.org/8765 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
