Reviewers: Kevin Millikin, Description: Use 1 byte push REG instructions instead of the 2 byte ModRM version.
Please review this at http://codereview.chromium.org/9111 Affected files: M src/builtins-ia32.cc M src/ic-ia32.cc Index: src/builtins-ia32.cc diff --git a/src/builtins-ia32.cc b/src/builtins-ia32.cc index 0de381c5ef8ed60d5858943cff148a3f395d3e73..92a24dddd5da201ba6b8a5a45772d9b3478f6889 100644 --- a/src/builtins-ia32.cc +++ b/src/builtins-ia32.cc @@ -657,7 +657,7 @@ static void EnterArgumentsAdaptorFrame(MacroAssembler* masm) { // arguments and the receiver. ASSERT(kSmiTagSize == 1); __ lea(ecx, Operand(eax, eax, times_1, kSmiTag)); - __ push(Operand(ecx)); + __ push(ecx); } Index: src/ic-ia32.cc diff --git a/src/ic-ia32.cc b/src/ic-ia32.cc index 82eb14d9d3a4b89e8864596df572f20c6aab158a..3f56031513e3f2e4200707030bb62b801b705c78 100644 --- a/src/ic-ia32.cc +++ b/src/ic-ia32.cc @@ -538,8 +538,8 @@ void CallIC::Generate(MacroAssembler* masm, __ EnterInternalFrame(); // Push the receiver and the name of the function. - __ push(Operand(edx)); - __ push(Operand(ebx)); + __ push(edx); + __ push(ebx); // Call the entry. CEntryStub stub; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
