LGTM. Don't you need to fix the ARM codegen though? On Tue, Nov 4, 2008 at 4:41 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Do not put failures in handles. > > Assert in the Handle constructor that the object is not a failure. > > I have run our own tests in debug mode and the WebKit layout tests in > debug mode and there are no regressions. > > Please review this at http://codereview.chromium.org/9114 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/codegen-ia32.cc > M src/execution.cc > M src/handles-inl.h > M src/jsregexp.cc > M src/messages.cc > M src/objects.cc > M src/runtime.cc > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
