Lgtm!
http://codereview.chromium.org/9692/diff/1/2 File regexp2000/src/jsregexp.cc (right): http://codereview.chromium.org/9692/diff/1/2#newcode840 Line 840: result->data_.u_store_position.reg_ = reg; Consider either adding an u_restore_position entry in data_ or rename u_store_position to something more general that covers both uses. http://codereview.chromium.org/9692/diff/1/2#newcode1003 Line 1003: out->stream()->Add("label=\"$pos=$%i\", shape=box", I've been using ':=', not '='. http://codereview.chromium.org/9692 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
