LGTM
http://codereview.chromium.org/9328/diff/220/233 File src/jump-target-arm.h (right): http://codereview.chromium.org/9328/diff/220/233#newcode35 Line 35: // ------------------------------------------------------------------------- Almost everything in this file looks architecture independent - should be factored out at some point. http://codereview.chromium.org/9328/diff/220/232 File src/jump-target.h (right): http://codereview.chromium.org/9328/diff/220/232#newcode31 Line 31: #if defined(ARM) || defined (__arm__) || defined(__thumb__) This is kinda messy. I don't have a better suggestion right now, but perhaps the solution becomes obvious once the commonality is factored out of these two include files. http://codereview.chromium.org/9328/diff/220/226 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/9328/diff/220/226#newcode46 Line 46: parameter_count_ = cgen->scope()->num_parameters(); I think you should be using the initalizer list syntax here. http://codereview.chromium.org/9328 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
