Lgtm, with comments.
http://codereview.chromium.org/10252/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/10252/diff/1/2#newcode239 Line 239: if (js_args.argc() > 0) { We should consider defining this always, even when no arguments are given, to support the standard method of reading (optional) arguments more straightforwardly. var first = arguments[0] || (default value) http://codereview.chromium.org/10252/diff/1/3 File src/flag-definitions.h (right): http://codereview.chromium.org/10252/diff/1/3#newcode74 Line 74: struct JSArguments { I wonder if we can find a more general name for this, since it's a general mechanism that we happen to use for script arguments. http://codereview.chromium.org/10252 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
