http://codereview.chromium.org/10254/diff/1/3 File src/jsregexp.cc (right):
http://codereview.chromium.org/10254/diff/1/3#newcode672 Line 672: class SubAnalysisData: public AnalysisData { The 'Sub' was meant to convey that the result is a "child" of the prev data given to the constructor. But builder is a much better name. http://codereview.chromium.org/10254/diff/1/3#newcode832 Line 832: visited_(false) { } Yes, but it does no harm if you don't catch it until you meet the next choice node. In any case I expect to change the structure so this is just temporary. http://codereview.chromium.org/10254/diff/1/3#newcode986 Line 986: fprintf(stderr, "--- %p ---\n", static_cast<void*>(this)); It turns out I can use OS::PrintError. Also, I'll guard all this with #ifdef DEBUG. http://codereview.chromium.org/10254/diff/1/6 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/10254/diff/1/6#newcode610 Line 610: Execute("(a|b|c|\\w|\\s)", "", true); True, but damn convenient. http://codereview.chromium.org/10254 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
