Lgtm
http://codereview.chromium.org/10294/diff/7/11 File src/flags.cc (right): http://codereview.chromium.org/10294/diff/7/11#newcode201 Line 201: if (str) { How about buffer.Add("%s", str ? str : "NULL"); http://codereview.chromium.org/10294/diff/7/15 File src/string-stream.cc (right): http://codereview.chromium.org/10294/diff/7/15#newcode146 Line 146: EmbeddedVector<char, 24> formatted; Is 24 enough in all cases? http://codereview.chromium.org/10294 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
