http://codereview.chromium.org/10830/diff/1/4 File src/regexp-macro-assembler.h (right):
http://codereview.chromium.org/10830/diff/1/4#newcode45 Line 45: virtual void EmitOrLink(Label* label) = 0; On 2008/11/12 14:07:23, lrn wrote: > What does this do? Shouldn't this be in the underlying assembler, if the macro > assembler need it? > (I.e., which generic algorithm, based on the interface of the macro assembler, > will need to emit a raw label? Or emit anything directly?) The switch code for Choice nodes needs to emit a table of destinations for the table. The destination nodes have not necessarily been code generated yet, but we can get their labels and use this function to fill in the table. http://codereview.chromium.org/10830/diff/1/4#newcode72 Line 72: Vector<const uc16> str, On 2008/11/12 14:07:23, lrn wrote: > This sends a raw vector as argument. Are we certain this will work if the called > function triggers a GC? I think the data that we are using as input is not going to be in the JS heap. http://codereview.chromium.org/10830 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
