Small comments below. Otherwise LGTM. -Ivan
http://codereview.chromium.org/10634/diff/1/5 File SConstruct (right): http://codereview.chromium.org/10634/diff/1/5#newcode110 Line 110: 'WARNINGFLAGS': ['/wd4996'] Is it possible to add an explanation why we are hiding the warning here? http://codereview.chromium.org/10634/diff/1/4 File src/simulator-arm.cc (right): http://codereview.chromium.org/10634/diff/1/4#newcode391 Line 391: v8::internal::Thread::SetThreadLocal(simulator_key, sim); Since there is no AttachCurrentThread/DetachCurrentThread in the API we will be leaking these simulators and their associated thread states. I know that the thread switching code tries to somehow deal with that. You should file a bug to deal with this at some later point. http://codereview.chromium.org/10634 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
