LGTM
http://codereview.chromium.org/10682/diff/1/3 File src/jsregexp.cc (right): http://codereview.chromium.org/10682/diff/1/3#newcode1545 Line 1545: table->AddRange(CharacterRange(last, 0xFFFF), index); I think this goes wrong if range.to() for the last range is 0xfffe. I imagine there will be literally trillions of regexps with ranges ending in one, but not the other BOM symbol, so it's important to get this right! http://codereview.chromium.org/10682/diff/1/7 File src/utils.h (right): http://codereview.chromium.org/10682/diff/1/7#newcode87 Line 87: static int Spaceship(const T& a, const T& b) { The reasoning behind this name is a little opaque to me. Also it seems a pity that it is only ever used for uc16s where 'return a - b' would be faster. http://codereview.chromium.org/10682 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
