It would be a good idea to have another set of eyes on it. It's pretty much a straight port of the same thing for IA-32. I want to make sure that the two platforms stay in sync so it is not a lot of work to merge back to bleeding_edge when we're ready.
On Thu, Nov 13, 2008 at 3:33 PM, Erik Corry <[EMAIL PROTECTED]> wrote: > Can't get Rietveld to publish my comments. > > It still says reincarnate in one of the comments, but the word has been > removed from the other comments. Probably should be removed from them all > for consistency, > > As discussed offline the VirtualFrames should probably be zone allocated > for efficiency. A task for later. > > Most of it LGTM, but I didn't have the time/energy to review the big one, > codegen-arm.cc yet. Anyone else (Ivan?) is welcome to take a look. You > have to download the raw patch set because the diff is too large to display. > > > On Thu, Nov 13, 2008 at 2:47 PM, Kevin Millikin <[EMAIL PROTECTED]>wrote: > >> OK, it passes our tests now. Could you take a look? >> >> >> On Wed, Nov 12, 2008 at 2:38 PM, Kevin Millikin <[EMAIL PROTECTED]>wrote: >> >>> FYI, there are some failures on the ARM simulator that I'm working out. >>> You can hold off an looking too closely at this and I'll let you know when >>> I have an updated CL up. >>> >>> >>> On Wed, Nov 12, 2008 at 11:41 AM, <[EMAIL PROTECTED]> wrote: >>> >>>> >>>> Reviewers: Erik Corry, >>>> >>>> Message: >>>> There is platform-independent code in the platform-specific files that >>>> can be factored out. That will be coming soon to a changelist near you. >>>> >>>> Description: >>>> Experimental: Finish porting jump target changes to the ARM platform. >>>> The v8 test suite passes on the simulator. >>>> >>>> Please review this at http://codereview.chromium.org/10829 >>>> >>>> SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ >>>> >>>> Affected files: >>>> M src/codegen-arm.h >>>> M src/codegen-arm.cc >>>> M src/codegen-ia32.cc >>>> M src/jump-target-arm.cc >>>> M src/jump-target-ia32.cc >>>> D src/virtual-frame-arm-inl.h >>>> M src/virtual-frame-arm.h >>>> M src/virtual-frame-arm.cc >>>> M src/virtual-frame-ia32.h >>>> M src/virtual-frame-ia32.cc >>>> >>>> >>>> >>>> >>>> >>> >> >> >> > > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen > K, Denmark. > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
