LGTM
http://codereview.chromium.org/10943/diff/1/7 File src/jsregexp.cc (right): http://codereview.chromium.org/10943/diff/1/7#newcode649 Line 649: ASSERT_EQ(regexp->TypeTag(), JSRegExp::RE2K); This method looks like an almost, but not entirely, complete copy of JsreExecGlobal. Could some of it be abstracted into one function? http://codereview.chromium.org/10943/diff/1/7#newcode821 Line 821: int capture_count) { Also need to know if we ignore case. http://codereview.chromium.org/10943 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
